Review Request 112992: always reload now playing text

David Edmundson david at davidedmundson.co.uk
Wed Oct 2 18:45:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112992/#review41139
-----------------------------------------------------------

Ship it!


(FYI, no need to add my name to the reviewers, I see everything in group telepathy, you can save yourself some typing)

- David Edmundson


On Oct. 1, 2013, 8:31 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112992/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 8:31 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Bugs: 305820
>     http://bugs.kde.org/show_bug.cgi?id=305820
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Nowplaying text only loads if plugin changes from disable -> enable, this patch make it always reload the nowplayingtext when setting changes.
> 
> 
> Diffs
> -----
> 
>   telepathy-mpris.cpp 4236e39 
> 
> Diff: http://git.reviewboard.kde.org/r/112992/diff/
> 
> 
> Testing
> -------
> 
> bug is fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131002/6d5eb261/attachment.html>


More information about the KDE-Telepathy mailing list