Review Request 113033: Make contact IDs in contact details widget selectable

Elias Probst mail at eliasprobst.eu
Wed Oct 2 11:00:58 UTC 2013



> On Oct. 1, 2013, 10:43 p.m., David Edmundson wrote:
> > This needs doing for all the details widgets in kpeople, email, phone numbers etc.
> > 
> > Can someone reading this please copy & paste this line into kpeople/widgets/plugins
> 
> Elias Probst wrote:
>     There you go: https://git.reviewboard.kde.org/r/113044/
> 
> Martin Klapetek wrote:
>     Elias, do you have commit access? Or should we commit it for you?

Please commit for me, I don't have access.


- Elias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113033/#review41085
-----------------------------------------------------------


On Oct. 1, 2013, 9:40 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113033/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 9:40 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 325510
>     http://bugs.kde.org/show_bug.cgi?id=325510
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This patch makes the contact ID in the contact details widget selectable.
> 
> 
> Diffs
> -----
> 
>   kpeople/uiplugins/imdetailswidget.cpp 761e18dbdb1f077924756d7714ccba472ae73411 
> 
> Diff: http://git.reviewboard.kde.org/r/113033/diff/
> 
> 
> Testing
> -------
> 
> Tested against current master of all KTP components.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of selected contact ID
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/01/0ac5393c-013e-4e95-a8af-0d1fd0d3c90c__selectable.png
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131002/88f2264d/attachment.html>


More information about the KDE-Telepathy mailing list