Review Request 114132: Plasmoid Contact: Implemented files transfer by drag'n'drop.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114132/#review44797
-----------------------------------------------------------


This review has been submitted with commit 4e8af8f9ade45ee2a9f97d8748f3f6beab119868 by Alexandr Akulich to branch master.

- Commit Hook


On Nov. 29, 2013, 12:30 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114132/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 12:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 288562
>     http://bugs.kde.org/show_bug.cgi?id=288562
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Contact: Implemented files transfer by drag'n'drop.
> 
> 
> Diffs
> -----
> 
>   contact/src/contact-wrapper.h 778a7a0 
>   contact/src/contact-wrapper.cpp 6ff1be4 
>   contact/src/declarative/contents/ui/Avatar.qml 4bdeb11 
> 
> Diff: http://git.reviewboard.kde.org/r/114132/diff/
> 
> 
> Testing
> -------
> 
> Works almost as expected, but user experience is bad:
> If filetransfer is not available, then drag'n'drop event be catched by plasma, which default reaction is not suitable (it creates new plasmoids instances for each file).
> Would be much better to reject dnd event and indicate that drop isn't accepted, but DropEvent is not QEvent and I have no idea how to set "drop-not-accepted" cursor.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131129/73564f3a/attachment.html>