Review Request 114196: Plasmoid Contact: Implemented files transfer by appropriate button.

[David Edmundson]

> On Nov. 29, 2013, 11:34 a.m., Martin Klapetek wrote:
> > contact/src/contact-wrapper.cpp, line 267
> > <http://git.reviewboard.kde.org/r/114196/diff/1/?file=221288#file221288line267>
> >
> >     I think proper word for this is "Select"?

We use "choose" in the ktp-text-ui. (just tested).

I sort-of agree that select is better - but only if we change everything.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114196/#review44785
-----------------------------------------------------------


On Nov. 29, 2013, 11:32 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114196/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 11:32 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 288556
>     http://bugs.kde.org/show_bug.cgi?id=288556
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Contact: Implemented files transfer by appropriate button.
> 
> Added KIO dependency.
> 
> 
> Diffs
> -----
> 
>   contact/CMakeLists.txt 7a9415b 
>   contact/src/contact-wrapper.cpp b516960 
> 
> Diff: http://git.reviewboard.kde.org/r/114196/diff/
> 
> 
> Testing
> -------
> 
> It works! :-)
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131129/c307dbb2/attachment.html>