Review Request 114121: add sipe/sipe protocol support

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114121/#review44659
-----------------------------------------------------------


Pretty darn good patch, I like it! I'd like someone else to have a look (hello DrDanz!), but ship it from me.

Thanks :)


plugins/sipe/sipe-account-ui.h
<http://git.reviewboard.kde.org/r/114121/#comment31882>

    With return types the pointer sign goes to the left, eg. AbstractAccountParametersWidget* mainOptionsWidget(...)
    
    Also, if possible, try fitting this to one line, or only put the second argument on the next line



plugins/sipe/sipe-account-ui.h
<http://git.reviewboard.kde.org/r/114121/#comment31883>

    Same here



plugins/sipe/sipe-advanced-options-widget.ui
<http://git.reviewboard.kde.org/r/114121/#comment31884>

    The dialog seems unnecessary wide?
    
    Also, pro tip - when doing UI changes, always post a screenshot of your result ;)



plugins/sipe/sipe-main-options-widget.ui
<http://git.reviewboard.kde.org/r/114121/#comment31885>

    This on the other hand, seems to small? I think you can also just remove the absolute sizes from the .ui files


- Martin Klapetek


On Nov. 25, 2013, 8:32 p.m., Maksim Melnikau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114121/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 8:32 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> telepathy-sipe e.g. pidgin-sipe telepathy's backend support
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt e752ef1 
>   plugins/sipe/CMakeLists.txt PRE-CREATION 
>   plugins/sipe/Messages.sh PRE-CREATION 
>   plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION 
>   plugins/sipe/sipe-account-ui.h PRE-CREATION 
>   plugins/sipe/sipe-account-ui.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.h PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION 
>   plugins/sipe/sipe-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114121/diff/
> 
> 
> Testing
> -------
> 
> only basic testing done, not all advanced options tested 
> 
> 
> Thanks,
> 
> Maksim Melnikau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131128/ba2be67f/attachment.html>