Review Request 114106: KTp/Contact: Get rid few condition double-checks

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114106/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 3:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

KTp/Contact: Get rid few condition double-checks.

There is may be small performance issue: we query both contact and self capabilities, while if any of two ret false, another query is needless.
(I talk about code like such one:)
    bool contactCanHandleFiles = capabilities().fileTransfers();
    bool selfCanHandleFiles = manager()->connection()->selfContact()->capabilities().fileTransfers();
    return contactCanHandleFiles && selfCanHandleFiles;

I didn't change it and hope for smart compiler.


Diffs
-----

  KTp/contact.cpp 64dd49b 

Diff: http://git.reviewboard.kde.org/r/114106/diff/


Testing
-------

Tested in different states. Capabilities of contacts are same as before this change. There is no crashes or so.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/4954508e/attachment.html>