Review Request 113824: Refactor of Contact plasmoid

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113824/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 5:34 p.m.)


Review request for Telepathy.


Changes
-------

Fixed notifier of "isAccountOnline" property.
setup[Account,Contact]Connects renamed to connect[Account,Contact]Signals.
undo[Account,Contact]Connects renamed to disconnect[Account,Contact]Signals.

Restored mistakenly commented debug message.


Repository: ktp-desktop-applets


Description
-------

TelepathyContact:
    Removed qmlObject related stuff.
    m_contact renamed to m_contactWrapper as it should be.
    Setup context property before loading qml file.

ContactWrapper:
    Properties placed there them should be.
    Added property isContactOnline;
    Added notifier-signals information for properties.
    Property canStartVideo renamed to canStartVideoCall (like canStartAudioCall).

    undoAccountConnects() reimplemented to don't break connections possible maked outside.
    Same about undoContactConnects().

    Methods reordered in cpp file to group simular methods together.
    Implemented updateProperties(). In future it's possible to implement granulated properties updating.
    Added checks for isAccountOnline in presenceStatus().
    Fixed coding-style.

QML part:
    Get rid a lot of functions, that anyway doesn't work properly.
    Get rid a lot of useless properties.
    Don't check avatarPresenceStatus for empty string and don't replace it with default one, because it's already done in c++ part.
    Get rid a lot of "anchors.fill: parent" and such, because it's bad practice to let children position itself on parent.
    Comminication buttons reordered like in KDE IM Contacts application.

Side effects:
    Fixed losted after few went offline/online presenceStatus.
    Fixed communication buttons remaining available after account becomes offline.


Diffs (updated)
-----

  contact/src/contact-wrapper.h 7b37907 
  contact/src/contact-wrapper.cpp 5ef5919 
  contact/src/declarative/contents/ui/Avatar.qml 6133563 
  contact/src/declarative/contents/ui/Contact.qml ab434c8 
  contact/src/declarative/contents/ui/DropDownMenu.qml 7177c70 
  contact/src/declarative/contents/ui/main.qml debb0ed 
  contact/src/telepathy-contact.h fe95c83 
  contact/src/telepathy-contact.cpp 67c8a32 

Diff: http://git.reviewboard.kde.org/r/113824/diff/


Testing
-------

Plasmoid state properly response on account and/or contact online/offline changing. Contact capabilities showed correctly.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/e3d93df6/attachment.html>