Review Request 113814: Small refactor of Telepathy KDED Module Plugins

[Alexandr Akulich]

> On Nov. 15, 2013, 4 p.m., Martin Klapetek wrote:
> > telepathy-kded-module-plugin.h, line 48
> > <http://git.reviewboard.kde.org/r/113814/diff/2/?file=212614#file212614line48>
> >
> >     the proper way to do this is 
> >     
> >     virtual void reloadConfig() = 0;

I'm not sure if there is possible plugin without config.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113814/#review43710
-----------------------------------------------------------


On Nov. 12, 2013, 4:21 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113814/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 4:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Small refactor of Telepathy KDED Module Plugins.
> 
> TelepathyKDEDModulePlugin: Added virtual public slot reloadConfig().
> AutoAway: Refactor readConfig() method to reloadConfig() slot.
> AutoAway: Get rid onSettingsChanged().
> ScreenSaverAway: Refactor readConfig() method to reloadConfig() slot.
> ScreenSaverAway: Get rid onSettingsChanged().
> TelepathyMPRIS: Rename onSettingsChanged() to reloadConfig().
> 
> Module: Connect settingsChanged() to reloadConfig() plugins slot.
> 
> Get rid some useless includes.
> 
> 
> Diffs
> -----
> 
>   autoaway.h 9496047 
>   autoaway.cpp ec2afb6 
>   contactnotify.h e3a5bb6 
>   screensaveraway.h 9332953 
>   screensaveraway.cpp 14f2092 
>   telepathy-kded-module-plugin.h ac960e2 
>   telepathy-module.cpp 19604bb 
>   telepathy-mpris.h f9469f1 
>   telepathy-mpris.cpp a014b51 
> 
> Diff: http://git.reviewboard.kde.org/r/113814/diff/
> 
> 
> Testing
> -------
> 
> Compilation and plugin settings re-applying works fine.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/5abcd8df/attachment.html>