Review Request 113842: Fix sorting in declarative contacts-model

[Siddhartha Sahu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113842/
-----------------------------------------------------------

(Updated Nov. 23, 2013, 12:29 a.m.)


Review request for Telepathy.


Changes
-------

Split setRoleNames to its own function

This is not working yet


Repository: ktp-common-internals


Description
-------

This is working only sporadically.

Is it because of setSourceModel being called from elsewhere too.
The model seems to contain all the role names even when the sorting fails (in which case sorting seems random)


Diffs (updated)
-----

  KTp/Models/contacts-model.h e6fb7b1 
  KTp/Models/contacts-model.cpp 0f69eb5 

Diff: http://git.reviewboard.kde.org/r/113842/diff/


Testing
-------

Not working perfectly yet.


Thanks,

Siddhartha Sahu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131122/b06d3e85/attachment.html>