Review Request 113837: Acknowledge received messages from declarative model

[Siddhartha Sahu]

> On Nov. 13, 2013, 9:02 p.m., David Edmundson wrote:
> > KTp/Declarative/conversations-model.cpp, line 129
> > <http://git.reviewboard.kde.org/r/113837/diff/2/?file=213920#file213920line129>
> >
> >     I don't understand why we do this.
> >     
> >     Can you explain it to me.

Sure.

So if I'm chatting with contact A, and contact B sends me a message, it gets loaded in the QML view, only is hidden.  When I click contact B, this method gets called to acknowledge the messages. I did not find a way to acknowledge from QML itself (which btw will be ideal).


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113837/#review43598
-----------------------------------------------------------


On Nov. 13, 2013, 8:10 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113837/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 8:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This acknowledges only in case the messages were loaded but were not shown.
> Acknowledgement for message in current chat is done from QML itself.
> 
> Can we move this to QML too?
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversations-model.cpp 4e3489a 
>   KTp/Declarative/messages-model.h 24d2cb8 
> 
> Diff: http://git.reviewboard.kde.org/r/113837/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131113/692dec48/attachment.html>