Review Request 113842: Fix sorting in declarative contacts-model

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113842/#review43596
-----------------------------------------------------------



KTp/Models/contacts-model.cpp
<http://git.reviewboard.kde.org/r/113842/#comment31331>

    This is wrong.
    Only updateGroupProxyModels should call setSourceModel, as it works out what the sourcemodel should be (which is not always this)


I do remember something was wrong with the role names though. 

Who sets the role names? Maybe we can move setting the role names to this class only.

- David Edmundson


On Nov. 13, 2013, 2:47 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113842/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 2:47 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This is working only sporadically.
> 
> Is it because of setSourceModel being called from elsewhere too.
> The model seems to contain all the role names even when the sorting fails (in which case sorting seems random)
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-model.cpp 0f69eb5 
> 
> Diff: http://git.reviewboard.kde.org/r/113842/diff/
> 
> 
> Testing
> -------
> 
> Not working perfectly yet.
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131113/272a325c/attachment.html>