Review Request 113832: Contact: Implemented audio/video calls.

[Alexandr Akulich]

> On Nov. 13, 2013, 5:58 p.m., Martin Klapetek wrote:
> >
> 
> Alexandr Akulich wrote:
>     I also prefer your variant, but uses same style, as in methods above those two.
>     There is
>         Tp::PendingChannelRequest* channelRequest = KTp::Actions::startChat(m_account, m_contact);
>     coded before me. (http://quickgit.kde.org/?p=ktp-desktop-applets.git&a=blob&f=contact%2Fsrc%2Fcontact-wrapper.cpp line 206)
>     
>     Can I mix style fixing and implementation review-request and fix existed one as well?

I just think that I can fix style of existed code in my previous RR with refactor and commit there implementation with right style.
Sorry for noise.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113832/#review43575
-----------------------------------------------------------


On Nov. 13, 2013, 4:28 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113832/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 4:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Contact: Implemented startAudioCall(), startVideoCall().
> 
> 
> Diffs
> -----
> 
>   contact/src/contact-wrapper.cpp 5ef5919 
> 
> Diff: http://git.reviewboard.kde.org/r/113832/diff/
> 
> 
> Testing
> -------
> 
> Contact plasmoid can start audio and video calls.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131113/647c2828/attachment.html>