Review Request 113832: Contact: Implemented audio/video calls.

Martin Klapetek martin.klapetek at gmail.com
Wed Nov 13 11:58:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113832/#review43575
-----------------------------------------------------------



contact/src/contact-wrapper.cpp
<http://git.reviewboard.kde.org/r/113832/#comment31314>

    As per our coding style - the pointer sign goes to the variable, so 
    Tp::PendingChannelRequest *channelRequest
    



contact/src/contact-wrapper.cpp
<http://git.reviewboard.kde.org/r/113832/#comment31315>

    Same here


- Martin Klapetek


On Nov. 13, 2013, 10:28 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113832/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 10:28 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Contact: Implemented startAudioCall(), startVideoCall().
> 
> 
> Diffs
> -----
> 
>   contact/src/contact-wrapper.cpp 5ef5919 
> 
> Diff: http://git.reviewboard.kde.org/r/113832/diff/
> 
> 
> Testing
> -------
> 
> Contact plasmoid can start audio and video calls.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131113/8b910a77/attachment.html>


More information about the KDE-Telepathy mailing list