Review Request 113803: TelepathyMPRIS: Refactor.

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113803/
-----------------------------------------------------------

(Updated Nov. 12, 2013, 9:49 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: ktp-kded-module


Description
-------

Get rid unnecessary include.                                                                                                                                                                                                                                                   
Extract few string constants to static const string.                                                                                                                                                                                                                           
Replace QString::contains() by startsWith() in service prefix matching.                                                                                                                                                                                                        
Rename newMediaPlayer() to watchPlayer() (inspired by unwatchAllPlayers()).                                                                                                                                                                                                    
Rename m_knownPlayers to m_watchedPlayers.                                                                                                                                                                                                                                     
Move few public slots to private slots or methods.


Diffs
-----

  telepathy-mpris.h c223e94 
  telepathy-mpris.cpp 93875fe 

Diff: http://git.reviewboard.kde.org/r/113803/diff/


Testing
-------

Looks like it works as well, as before refactor. (Tested with amarok and dragon player).


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131112/14c6bf46/attachment.html>