Review Request 113802: TelepathyKDEDModulePlugin: Get rid unnecessary include
Alexandr Akulich
akulichalexander at gmail.com
Tue Nov 12 07:23:46 UTC 2013
> On Nov. 12, 2013, 4:32 a.m., David Edmundson wrote:
> > Thanks. Do you have commit access?
>
> Martin Klapetek wrote:
> In case you're going to commit it, please also include "removing useless semicolons" to the commit message or do a separate commit for that, thanks :)
I haven't commit access. Commit message in diff is:
TelepathyKDEDModulePlugin: Get rid unnecessary include and ';'.
in one line to fit in 80 symbols. If it's ok to not mention about semicolons in first line, then "removing useless semicolons" seems is better than just ';'.
- Alexandr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113802/#review43475
-----------------------------------------------------------
On Nov. 12, 2013, 1:55 a.m., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113802/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 1:55 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-kded-module
>
>
> Description
> -------
>
> TelepathyKDEDModulePlugin: Get rid unnecessary include
>
>
> Diffs
> -----
>
> telepathy-kded-module-plugin.h 9d1ff20
>
> Diff: http://git.reviewboard.kde.org/r/113802/diff/
>
>
> Testing
> -------
>
> Successfully compiled.
>
>
> Thanks,
>
> Alexandr Akulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131112/aac2d9e0/attachment.html>
More information about the KDE-Telepathy
mailing list