Review Request 113582: Make sorting in user list case-insensitive and locale aware

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113582/#review42824
-----------------------------------------------------------

Ship it!



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/113582/#comment30973>

    This includes your previous patch. 
    
    We try to avoid that (particularly if these were larger unrelated changes)



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/113582/#comment30972>

    This red block in the the diff shows that you've added 4 spaces on the line below. 
    
    If you use kate/kdevelop you can set the editor up to not include added whitespace when it saves the document


- David Edmundson


On Nov. 2, 2013, 9:01 a.m., Ilya Katsnelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113582/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2013, 9:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> That makes it work the same way ktp-contact-list works.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp c2b5a97e739fc78267a243c8e36a9d6efdb98c1c 
> 
> Diff: http://git.reviewboard.kde.org/r/113582/diff/
> 
> 
> Testing
> -------
> 
> Tested on multiple chatrooms, en_US and ru_RU locales.
> 
> 
> Thanks,
> 
> Ilya Katsnelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131102/de1fee11/attachment.html>