Review Request 110739: Create and cache the contact groups

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110739/#review33529
-----------------------------------------------------------

Ship it!


There is a hypothetical issue that if the group were to be deleted by an external source the cache is now pointing to URIs that don't exist. Do you see this as something that would be a problem?


nepomuk-storage.cpp
<http://git.reviewboard.kde.org/r/110739/#comment24784>

    That's fine. This code has no UI.


- David Edmundson


On May 30, 2013, 6:47 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110739/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 6:47 p.m.)
> 
> 
> Review request for Telepathy, Aleix Pol Gonzalez, David Edmundson, and Martin Klapetek.
> 
> 
> Description
> -------
> 
>     Create and cache the contact groups
>     
>     Earlier, if a group contained more than one contact then it the contact
>     group was created that many times cause a new SimpleResource was created
>     each time.
>     
>     With this method we cache the contact groups so that they are only
>     created once, and once they have been created we do not unnecessarily
>     send a new SimpleResource to get merged into the existing contact group.
> 
> 
> Diffs
> -----
> 
>   nepomuk-storage.h ad5b6bc 
>   nepomuk-storage.cpp adee609 
> 
> Diff: http://git.reviewboard.kde.org/r/110739/diff/
> 
> 
> Testing
> -------
> 
> No more duplicate contact groups.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130531/fd43e2bd/attachment.html>