Review Request 110717: Remove alt tag from images inserted with ImageFilter

[Aleix Pol Gonzalez]

> On May 29, 2013, 8:35 p.m., Aleix Pol Gonzalez wrote:
> > So is clicking emoticons and getting the text a bug? I was convinced that it was actually a feature, I do it regularly and I was mentally pushing myself into doing for the chat plasmoid, because I think it's a good idea...
> 
> David Edmundson wrote:
>     Nooo. That part is intentional for emoticons.
>     
>     But if I send you a normal link to a picture, Template.html thinks it is an emoticon and changes the picture to the alt text we have for the normal picture.
>     
>     When you click on a normal picture (not an emoticon) it should open the full image, and not change.
>     
>     I want the emoticon behaviour for emoticons, I do not want it for normal images.
>     
>

Ah, makes sense now.

It's a "Ship it" from me then :).


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110717/#review33378
-----------------------------------------------------------


On May 29, 2013, 6:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110717/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 6:58 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove alt tag from images inserted with ImageFilter
> 
> This alt tag never actually showed up (not sure why).
> Removing this means the emoticon -> text swapping no longer occurs so images remain after being clicked fixing a bug.
> 
> BUG: 305078
> 
> 
> Diffs
> -----
> 
>   filters/images/images-filter.cpp dc347744d7acbd375229b31da94fb19ef24296c6 
> 
> Diff: http://git.reviewboard.kde.org/r/110717/diff/
> 
> 
> Testing
> -------
> 
> Sent emoticon and image URL to myself.
> 
> Emoticon behaves with clicking -> text -> restore. 
> Image works like a normal link.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130529/5e896b80/attachment-0001.html>