Review Request 110710: Fix wrong rowcount in ChannelContactModel
Aleix Pol Gonzalez
aleixpol at kde.org
Wed May 29 13:55:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110710/#review33353
-----------------------------------------------------------
Ship it!
lib/channel-contact-model.cpp
<http://git.reviewboard.kde.org/r/110710/#comment24672>
isn't it better to use !newContacts.isEmpty()?
- Aleix Pol Gonzalez
On May 29, 2013, 1:29 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110710/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 1:29 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Fix wrong rowcount in ChannelContactModel
>
> BUG: 320352
>
>
> Diffs
> -----
>
> lib/channel-contact-model.cpp 109e6b14769e362c1e9ac7af60ba49c15bb1ff47
>
> Diff: http://git.reviewboard.kde.org/r/110710/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130529/6744f629/attachment.html>
More information about the KDE-Telepathy
mailing list