Review Request 110614: Chat plasmoid: Improve conversation following

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110614/
-----------------------------------------------------------

(Updated May 23, 2013, 2:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and David Edmundson.


Description
-------

Use the contentHeight instead of the count property. The difference is that sometimes the view size would change when the section delegate is added and lose the positioning.

I had tried contentHeight changes before, but it was before having the full conversation items in memory, so that will be a difference now.


This addresses bug 317853.
    http://bugs.kde.org/show_bug.cgi?id=317853


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 7656ae4 

Diff: http://git.reviewboard.kde.org/r/110614/diff/


Testing
-------

I've been using it for many days (I've decided that's the only way to test this plasmoid, or at least such features). It seems to work OK.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130523/8e719103/attachment.html>