Review Request 110552: Do not remove conversation from model on validity changes

[David Edmundson]

> On May 21, 2013, 10:45 p.m., Aleix Pol Gonzalez wrote:
> > KTp/Declarative/conversation.cpp, line 97
> > <http://git.reviewboard.kde.org/r/110552/diff/1/?file=145743#file145743line97>
> >
> >     It seems a bit weird to me API-wise that the delegate method removes the conversation from the model while it's not needed, only useful UI-wise.
> >     
> >     Isn't it?

The delegate method does exactly what it did before. All I've done is move that behavior from ConversationsModel to Conversation.

Removing delegates channels from the conversation model is something you wrote.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110552/#review32945
-----------------------------------------------------------


On May 22, 2013, 10:34 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110552/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 10:34 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Do not remove conversation from conversation-model on validity changes. This means we can have conversations in the plasmoid persistent across reconnections and network drops.
> 
> This won't be merged until the other issues that I mentioned in the relevant bug report are fixed, I'm posting because it's better to do reviews in small stages.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversation.h 6fc8903cc649af266789d70daf3b15361184c002 
>   KTp/Declarative/conversation.cpp 6820913e3614d3bf6c8089f481f0c20bd681cf01 
>   KTp/Declarative/conversations-model.h cb4d2e0fc33b5feb82c01c439cf81c7f67028182 
>   KTp/Declarative/conversations-model.cpp 9cb7e47bcdaa70377d9da8f926ebdb0854f3a756 
> 
> Diff: http://git.reviewboard.kde.org/r/110552/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130522/0131c0ec/attachment.html>