Review Request 110552: Do not remove conversation from model on validity changes

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110552/
-----------------------------------------------------------

(Updated May 22, 2013, 10:34 a.m.)


Review request for Telepathy.


Description (updated)
-------

Do not remove conversation from conversation-model on validity changes. This means we can have conversations in the plasmoid persistent across reconnections and network drops.

This won't be merged until the other issues that I mentioned in the relevant bug report are fixed, I'm posting because it's better to do reviews in small stages.


Diffs
-----

  KTp/Declarative/conversation.h 6fc8903cc649af266789d70daf3b15361184c002 
  KTp/Declarative/conversation.cpp 6820913e3614d3bf6c8089f481f0c20bd681cf01 
  KTp/Declarative/conversations-model.h cb4d2e0fc33b5feb82c01c439cf81c7f67028182 
  KTp/Declarative/conversations-model.cpp 9cb7e47bcdaa70377d9da8f926ebdb0854f3a756 

Diff: http://git.reviewboard.kde.org/r/110552/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130522/0abcc88c/attachment.html>