Review Request 110334: %time Variable to get the current UTC time in the away message

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110334/#review32898
-----------------------------------------------------------


The code looks fine, but I'd rather use the actual timezone of the user that went away instead of the UTC (see https://qt-project.org/doc/qt-4.8/qtime.html#toString "t" option).
But if the others are ok with it, it's ok with me as well.


P.S. Sorry if it took so long for my review but I'm very busy in this period :(

- Daniele E. Domenichelli


On May 9, 2013, 3:19 p.m., Lucas Betschart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110334/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 3:19 p.m.)
> 
> 
> Review request for Telepathy and Daniele E. Domenichelli.
> 
> 
> Description
> -------
> 
> I've added an %time option which will get replaced by the current UTC time.
> 
> To make this option visible I've changed the tool tip (I think the first thing a user would do if he wants no away message is to remove the message text [if there is one, which isn't by default], so this double information can be replaced).
> 
> Adding an extra widget for drag n drop like in now playing would be too much for this I think. It would blow up the UI if I add this under every lineedit (as more stuff is visible on the first sight for the user as more complicated it looks) and it would be confusing if I add it only once in a central place, so I decided to just inform the user through a tool tip (it's also not a important feature, so it's ok if it's a little bit hidden).
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=300849.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=300849
> 
> 
> Diffs
> -----
> 
>   autoaway.cpp 06cb8e05d84f250e59a373461cb709ec5d400471 
>   config/telepathy-kded-config.cpp 780a882858c1fed4968b71cf4c5832f9d43f7b7a 
>   screensaveraway.cpp c7fdd75aa2217a44ec849dc9acfbf20020524bdb 
> 
> Diff: http://git.reviewboard.kde.org/r/110334/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lucas Betschart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130521/1771bb0f/attachment.html>