Review Request 110545: Apply text-ui theme change immediatelly

Commit Hook null at kde.org
Tue May 21 12:49:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110545/#review32890
-----------------------------------------------------------


This review has been submitted with commit 62bb42b610fc4d9228ed77a61dbef143658d8340 by Dan Vrátil to branch master.

- Commit Hook


On May 20, 2013, 1:30 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110545/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 1:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The chat UI is reinitialized when theme is changed, the current conversations are reloaded from TpLogger.
> 
> I've ported LogManager to LogWalker, which simplifies and speeds up the code considerably. That means that text-ui now depends on TelepathyLoggerQt 0.8.0 (0.7.95) and TelepathyLogger 0.8.0 - make sure you have latest git build of TpLoggerQt otherwise you get crash on text-ui start. If everything works, I'll make TpLoggerQt 0.8.0 release soon (screw waiting for FD.O account).
> 
> Status notifications are not stored in logger, so after re-loading the chat they disappear, but I don't think that is a problem.
> 
> 
> This addresses bug 270350.
>     http://bugs.kde.org/show_bug.cgi?id=270350
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bb16e0b 
>   app/chat-window.h 47316a4 
>   app/chat-window.cpp 3a9b6e9 
>   config/appearance-config.h c0a1e69 
>   config/appearance-config.cpp f7ebd40 
>   lib/chat-widget.h 366d88b 
>   lib/chat-widget.cpp 39da92c 
>   lib/logmanager.h e5e97bc 
>   lib/logmanager.cpp 213b5aa 
> 
> Diff: http://git.reviewboard.kde.org/r/110545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130521/601ceab0/attachment.html>


More information about the KDE-Telepathy mailing list