Review Request 110445: Add 'Contact Details' action to incomming contact request

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110445/#review32553
-----------------------------------------------------------



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/110445/#comment24236>

    Do not do an exec() from inside KDED
    You will break /everything/
    
    set window to close on quit and use show.


I agree that's a clumsy way of getting the account, I also agree there's not a lot better.

I did have draft code that ported the kded to use GlobalContactManager which would make it easier. I never finished it because it didn't add anything, just tidied code. Is it worth me restoring/finishing that? 

- David Edmundson


On May 15, 2013, 12:51 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110445/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 12:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The way account is retrieved feels a bit clumsy, but I couldn't find anything better without rewriting half of the code :-)
> 
> 
> This addresses bug 298764.
>     http://bugs.kde.org/show_bug.cgi?id=298764
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.h 0042294 
>   contact-request-handler.cpp e30d2ca 
> 
> Diff: http://git.reviewboard.kde.org/r/110445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130515/7bbfd736/attachment.html>