Review Request 110439: Allow dynamic loading and unloading of text filters

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110439/#review32548
-----------------------------------------------------------



KTp/message-filter-config-manager.cpp
<http://git.reviewboard.kde.org/r/110439/#comment24233>

    will this still keep the plugin order?
    
    If not, that's a problem.



KTp/message-processor-private.h
<http://git.reviewboard.kde.org/r/110439/#comment24232>

    lies?


- David Edmundson


On May 15, 2013, 11:41 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110439/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 11:41 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add MessageFilterConfigManager::reloadConfig() that iterates through all plugins, checks whether they were enabled or disabled since last time and call MessageProcessor::Private::loadFilter() or unloadFilter().
> 
> 
> The reloadConfig() method will be called from MessagesConfig in ktp-text-ui/config when save() is called.
> 
> 
> This addresses bug 316887.
>     http://bugs.kde.org/show_bug.cgi?id=316887
> 
> 
> Diffs
> -----
> 
>   KTp/message-filter-config-manager.h fa7bc06 
>   KTp/message-filter-config-manager.cpp 70c4f81 
>   KTp/message-processor-private.h PRE-CREATION 
>   KTp/message-processor.h acbcd20 
>   KTp/message-processor.cpp db41ecf 
> 
> Diff: http://git.reviewboard.kde.org/r/110439/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130515/8892d624/attachment.html>