Review Request 110412: chat plasmoid: Small usability tweaks

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110412/#review32489
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On May 13, 2013, 2:27 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110412/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 2:27 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> We have the problem that sometimes the view doesn't get the focus when the view is open. I consider this a major bug and I'd like to fix it, although I'm unsure how to do that (I fear there's some plasma bug involved, but it's hard to tell since I cannot reproduce the bug with certainty).
> 
> This patch addresses small problems with the focus although it doesn't fix the main problem, but anyway:
> - makes sure the text field doesn't have the focus when it's closed (yeah, it happens, you can write to a non-visible window :D)
> - Removes a workaround I introduced thinking would be magic and solve all problems (because it's hard to reproduce). It didn't.
> - Makes sure the plasmoid knows there's no currentIndex when we've closed all windows.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 165974a 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml 2cc0851 
>   chat/org.kde.ktp-chat/contents/ui/main.qml 1451aaa 
> 
> Diff: http://git.reviewboard.kde.org/r/110412/diff/
> 
> 
> Testing
> -------
> 
> plasmoidviewer FTW
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130514/577b9f95/attachment.html>