Review Request 110378: let contact krunner also search contact with id
David Edmundson
david at davidedmundson.co.uk
Fri May 10 13:03:39 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110378/#review32312
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On May 10, 2013, 12:40 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110378/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 12:40 a.m.)
>
>
> Review request for Telepathy and Dan Vrátil.
>
>
> Description
> -------
>
> id is also useful for search, for xmpp it's usually the email address of corresponding account.
>
> Alias might be some unicode and thus search alias will take more effort for user in some languages (CJK for example).
>
>
> Diffs
> -----
>
> src/contactrunner.cpp 2ee63ae
>
> Diff: http://git.reviewboard.kde.org/r/110378/diff/
>
>
> Testing
> -------
>
> search by id now works.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130510/1053b9f5/attachment.html>
More information about the KDE-Telepathy
mailing list