Review Request 107012: Add an option to block an incoming contact

[Martin Klapetek]

> On May 6, 2013, 2:59 p.m., David Edmundson wrote:
> > Lets try and get this ready to merge. 
> > Actions listed are:
> >  - Add
> >  - Reject
> >  - Block
> > 
> > The reality is:
> > - Add
> > - Prompt me next time my account connects
> > - Reject + block
> > 
> > Personally I would just drop that middle option, and rename the third action (the "block") to "Reject".
> > 
> > If we are going to argue the case of having a "not now, prompt me later" option the UI _must_ reflect that this is what happens.
> >
> 
> Martin Klapetek wrote:
>     I'd go with dropping it as well. Delaying things is bad from so many POVs and we should not endorse it. Also, if you want to "decide later", you can just hide it (or we can add "Hide" option in the context menu, many SNIs have it).
> 
> Thomas Pfeiffer wrote:
>     I don't even think a "hide" button is necessary. There is the X icon for this, which is consistent across notifications. No need to add something specific to this notification, so I'm in favor of completely dropping the middle button as well.

Right, I meant not for notification, but for the StatusNotifierItem's context menu. I see some SNIs having a "Hide" menu entry but I just realized these are Kubuntu's own things. Of course "Hide" button on system notification is useless :)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107012/#review32140
-----------------------------------------------------------


On Oct. 23, 2012, 4:30 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107012/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 4:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add an option to block an incoming contact. This can be used to prevent a notification to be shown when being spammed with new contact requests.
> 
> 
> This addresses bugs 297994 and 308809.
>     http://bugs.kde.org/show_bug.cgi?id=297994
>     http://bugs.kde.org/show_bug.cgi?id=308809
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.h 43456ee 
>   contact-request-handler.cpp ea24885 
> 
> Diff: http://git.reviewboard.kde.org/r/107012/diff/
> 
> 
> Testing
> -------
> 
> Works fine. Once blocked, notification does not reappear. User can also accept a blocked request after unblocking the contact and resending contact authorization.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130507/7513785f/attachment-0001.html>