Review Request 110322: Add accept/reject actions to text channel approver

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110322/#review32164
-----------------------------------------------------------



src/textchannelapprover.cpp
<http://git.reviewboard.kde.org/r/110322/#comment23950>

    I think we could change "Reject" for "Discard" or "Close". Imho "Reject" suggests "give it back" while in fact the action is "dropping the channel". Dunno, just seems better to me.


- Martin Klapetek


On May 6, 2013, 12:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110322/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 12:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add accept/reject actions to text channel approver
> 
> Add contextmenu->clear() to remove useless title
> 
> BUG: 282583
> 
> 
> Diffs
> -----
> 
>   src/dispatchoperation.cpp a1a3327a243d6a9930a67e39fe3b3f48c4863405 
>   src/filetransferchannelapprover.cpp f4ddc40c99b971aa54898ed608e7f25b151e40e7 
>   src/textchannelapprover.cpp f8225ef09cc53c6d9c817304154174cbe3e66786 
>   src/tubechannelapprover.cpp 83978c32b19a388e70594a4f16390bf3633201e7 
> 
> Diff: http://git.reviewboard.kde.org/r/110322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130506/3d37f599/attachment-0001.html>