Review Request 110336: Restore last user presence but not if it was generated automatically by "Now Playing" plugin

David Edmundson david at davidedmundson.co.uk
Mon May 6 20:09:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110336/#review32158
-----------------------------------------------------------



telepathy-module.cpp
<http://git.reviewboard.kde.org/r/110336/#comment23945>

    If we have m_mpris why do we go through this complicated mechanism to get the m_mpris object again.
    
    TelepathyMPRIS is a subclass of TelepathyKDEDModulePlugin
    


- David Edmundson


On May 6, 2013, 7:39 p.m., Lucas Betschart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110336/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 7:39 p.m.)
> 
> 
> Review request for Telepathy and Alin M Elena.
> 
> 
> Description
> -------
> 
> I check now if the "Now Playing" plugin set the status message, if so, I don't save it.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=313126.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=313126
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp 3e71015aa9e6a0ac4861ced39ee77c792c4e6db3 
> 
> Diff: http://git.reviewboard.kde.org/r/110336/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lucas Betschart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130506/b5e34bd1/attachment.html>


More information about the KDE-Telepathy mailing list