Review Request 107012: Add an option to block an incoming contact

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107012/#review32140
-----------------------------------------------------------


Lets try and get this ready to merge. 
Actions listed are:
 - Add
 - Reject
 - Block

The reality is:
- Add
- Prompt me next time my account connects
- Reject + block

Personally I would just drop that middle option, and rename the third action (the "block") to "Reject".

If we are going to argue the case of having a "not now, prompt me later" option the UI _must_ reflect that this is what happens.


- David Edmundson


On Oct. 23, 2012, 4:30 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107012/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 4:30 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add an option to block an incoming contact. This can be used to prevent a notification to be shown when being spammed with new contact requests.
> 
> 
> This addresses bugs 297994 and 308809.
>     http://bugs.kde.org/show_bug.cgi?id=297994
>     http://bugs.kde.org/show_bug.cgi?id=308809
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.h 43456ee 
>   contact-request-handler.cpp ea24885 
> 
> Diff: http://git.reviewboard.kde.org/r/107012/diff/
> 
> 
> Testing
> -------
> 
> Works fine. Once blocked, notification does not reappear. User can also accept a blocked request after unblocking the contact and resending contact authorization.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130506/a57696ba/attachment.html>