Review Request 110291: Second iteration of settings dialog polishing

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110291/#review31998
-----------------------------------------------------------



config/nowplaying-listwidget.cpp
<http://git.reviewboard.kde.org/r/110291/#comment23844>

    I'd rather rather have
    
    sizeHintForRow(0) + 2 * (frameWidth() + 3); // add 3 to the top and bottom for padding round icons.


- David Edmundson


On May 3, 2013, 9:34 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110291/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 9:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is the second set of changes for the kded settings module. The changes are effectively very minor, but since I'm new to the code base I'd like to have them reviewed neverthereless. ;)
> 
> * Add a 3 pixel spacing at the top and the bottom of the icons list, as suggested on the other review request
> * Disable the labels, too, not just the input widgets (makes them look greyed out); for this I rearranged the code a bit otherwise it'd get ugly
> * Folder -> folder (this got lost in the diff, sorry)
> 
> Probably not much discussion is needed here. ;)
> 
> 
> Diffs
> -----
> 
>   config/nowplaying-listwidget.cpp 13aab1a 
>   config/telepathy-kded-config.h b1bf626 
>   config/telepathy-kded-config.cpp 5a7e91d 
>   config/telepathy-kded-config.ui 74ce51e 
> 
> Diff: http://git.reviewboard.kde.org/r/110291/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130504/ee99320d/attachment.html>