Review Request 110276: Revamp the settings user interface

Sven Brauch svenbrauch at gmx.de
Thu May 2 21:07:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110276/
-----------------------------------------------------------

(Updated May 2, 2013, 9:07 p.m.)


Review request for Telepathy, KDE Usability, David Edmundson, and Martin Klapetek.


Description
-------

This patch revamps the settings UI of the kded module. Especially, it removes the "flat" flag from the group boxes, and also removes lots of spacers. But talk doesn't really help with UI changes, so you'd better look at the screenshot below ;)

Additionally, I'd like to add a dialog->resize(700, 640) to ContactListWidget::showSettingsKCM() in contact-list-widget.cpp in ktp-contactlist (the function which opens the dialog), but I don't want to open a seperate review for that.


Diffs
-----

  config/telepathy-kded-config.cpp 50c176d 
  config/telepathy-kded-config.ui 54ebc54 

Diff: http://git.reviewboard.kde.org/r/110276/diff/


Testing
-------

The settings dialog still seems to work fine.


File Attachments
----------------

Old (left) and new (right) settings dialog, with their respective default sizes
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/ktp-settings.png


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130502/6a2207bf/attachment.html>


More information about the KDE-Telepathy mailing list