Review Request 110265: Work around bug that fails to display local-xmpp contacts.
David Edmundson
david at davidedmundson.co.uk
Wed May 1 22:26:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110265/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
Work around https://bugs.freedesktop.org/show_bug.cgi?id=57739.
Due to a bug in TelepathyQt if we request a feature that the connection does not support, it simply fails.
Local-XMPP does not support grouping, so salut the local-xmpp spec does not either.
When we request the ContactRosterGroups feature on all connections, salut fails and therefore doesn't show any contacts.
Fetching ContactRosterGroups seperately is not a viable option as contacts would move after loading
In this hack we make a new ConnectionFactory that fetches ContactRosterGroups on all connections _except_ salut
Diffs
-----
main-widget.cpp 92ff083365636dae1fc28fe56b58e7c08cfb225f
Diff: http://git.reviewboard.kde.org/r/110265/diff/
Testing
-------
Opened my contact list.. saw me on my laptop \o/
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130501/cf761c64/attachment.html>
More information about the KDE-Telepathy
mailing list