Review Request 110255: Added plugin to expand URL Shortener urls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110255/#review31835
-----------------------------------------------------------


Good work.

One big comment. any ->exec() in a UI thread almost always becomes a problem.


filters/urlexpansion/urlexpansion-filter.cpp
<http://git.reviewboard.kde.org/r/110255/#comment23736>

    I'm a bit worried about this.
    If we get a message and longurl.org is offline we now take 30 seconds (till timeout) whilst we are completely blocking the UI.
    
    I suggest we make this async, and if the user gets any short links before this finishes - tough luck to them.
    
    unless anyone can think of something better that isn't over-complicated? 



filters/urlexpansion/urlexpansion-filter.cpp
<http://git.reviewboard.kde.org/r/110255/#comment23737>

    const &


- David Edmundson


On May 1, 2013, 12:08 p.m., Anant Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110255/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 12:08 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Daniele E. Domenichelli.
> 
> 
> Description
> -------
> 
> The plugin checks for available services from longurl.org upon loading.
> 
> Filtering is done in the client via javascript. 
> 
> 
> This addresses bug 310512.
>     http://bugs.kde.org/show_bug.cgi?id=310512
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt c66e773 
>   filters/urlexpansion/CMakeLists.txt PRE-CREATION 
>   filters/urlexpansion/ktptextui_message_filter_urlexpansion.desktop.cmake PRE-CREATION 
>   filters/urlexpansion/longurl.js PRE-CREATION 
>   filters/urlexpansion/urlexpansion-filter.h PRE-CREATION 
>   filters/urlexpansion/urlexpansion-filter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110255/diff/
> 
> 
> Testing
> -------
> 
> Tested. Check screenshots.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/01/url1.png
> 
> 
> Thanks,
> 
> Anant Kamath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130501/b13d00fe/attachment.html>