Review Request 109807: Stop using mission-control for autoconnect

[David Edmundson]

> On March 31, 2013, 5:27 p.m., David Edmundson wrote:
> > In your opinion is it worth me pushing this into 0.6.0? (We've not tagged yet)
> 
> Dominik Cermak wrote:
>     Hmm, how about this:
>     I commit it to master so more people can test for races, and after some time (how long till tagging, there are 2 bugs for 0.6 left) we may pick it for 0.6 too.
> 
> Dominik Cermak wrote:
>     Or to keep the commit to branch, merge to master policy, commit to 0.6 merge to master and if we find problems before tagging revert it in 0.6?

I like the top idea. 
We can always pick it for 0.6.1


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109807/#review30177
-----------------------------------------------------------


On March 31, 2013, 4:50 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109807/
> -----------------------------------------------------------
> 
> (Updated March 31, 2013, 4:50 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Stop using mission-controls ConnectAutomatically for autoconnect, instead use our kded-module only.
> 
> The diff looks worse than it is. Most of the old code has been deleted, one new method has been added, but the unified diff mixes this all...
> 
> 
> This addresses bug 307175.
>     http://bugs.kde.org/show_bug.cgi?id=307175
> 
> 
> Diffs
> -----
> 
>   autoconnect.h e296012586a67aed88a87e2c166ff526ab0fa76d 
>   autoconnect.cpp 526b060db162e81accb6da0d1d81cb6dd22c43c0 
>   telepathy-module.cpp a28bca86f03e971ec7d68b62d69c8802d1b05677 
> 
> Diff: http://git.reviewboard.kde.org/r/109807/diff/
> 
> 
> Testing
> -------
> 
> Still testing if race conditions occur (auth-handler/kwallet timeout). So far no problems.
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130331/6e2b4671/attachment.html>