Review Request 109771: Fix set of spell cheking language during configuration loading
David Edmundson
david at davidedmundson.co.uk
Thu Mar 28 11:07:26 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109771/#review29986
-----------------------------------------------------------
Ship it!
Do you have commit access?
- David Edmundson
On March 28, 2013, 10:56 a.m., Eugene Shalygin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109771/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 10:56 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> KTextEdit::setSpellCheckingLanguage() does not do anything if there is no highlighter created yet, and KTextEdit::setCheckSpellingEnabled() does not create it if there is no focus on widget. Therefore
> d->ui.sendMessageBox->setSpellCheckingLanguage() call in ChatWidget::loadSpellCheckingOption() is ignored. While this looks like KTextEditor bug (espesially taking into account its documentation), just a call to KTextEditor::createHighlighter() before setting language fixes this.
>
> And I moved loadSpellCheckingOption() because createHighlighter() results in ChatWidget::onInputBoxChanged() call, where timers are used.
>
>
> Diffs
> -----
>
> lib/chat-widget.cpp 8df51c1
>
> Diff: http://git.reviewboard.kde.org/r/109771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eugene Shalygin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130328/5df21622/attachment.html>
More information about the KDE-Telepathy
mailing list