Review Request 109703: Don't crash when unknown service channel is accepted

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Mon Mar 25 09:30:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109703/#review29839
-----------------------------------------------------------

Ship it!


Ship It!

- Daniele E. Domenichelli


On March 25, 2013, 9:25 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109703/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 9:25 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When no service .desktop file is found, m_service will be null, so we crash when the channel is accepted.
> 
> 
> This addresses bug 317214.
>     http://bugs.kde.org/show_bug.cgi?id=317214
> 
> 
> Diffs
> -----
> 
>   src/tubechannelapprover.cpp fd2ff08 
> 
> Diff: http://git.reviewboard.kde.org/r/109703/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130325/adbdfa41/attachment.html>


More information about the KDE-Telepathy mailing list