Review Request 109696: Improvements for QML contactlist applet

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109696/#review29806
-----------------------------------------------------------


Looks like an awesome start, few comments.


contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml
<http://git.reviewboard.kde.org/r/109696/#comment22166>

    New string means this can't go into 0.6, we've miss the freeze.
    
    At least we will have a cool near feature for 0.7
    
    



contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml
<http://git.reviewboard.kde.org/r/109696/#comment22167>

    contactList.model already inherits from a  filtering model.
    
    KTp::ContactsFilterModel, this has better searching that will filter on a lot more things. We don't want to go through multiple proxies if we don't need to.
    
    See properties in that class.



contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml
<http://git.reviewboard.kde.org/r/109696/#comment22169>

    FYI you can do:
    
    anchors {
     top: foo
     left: foo
     right: foo
     bottom: foo
    }
    



contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml
<http://git.reviewboard.kde.org/r/109696/#comment22170>

    This is interesting. Maybe this needs putting into 0.6


- David Edmundson


On March 24, 2013, 8:01 p.m., Emil Sedgh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109696/
> -----------------------------------------------------------
> 
> (Updated March 24, 2013, 8:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> A filter for contacts
> Keyboard navigation
> ListItem highlighter
> 
> 
> Diffs
> -----
> 
>   contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml b5ad784 
> 
> Diff: http://git.reviewboard.kde.org/r/109696/diff/
> 
> 
> Testing
> -------
> 
> It seems work both as standalone (plasma-windowed), desktop applet and menu applet.
> 
> 
> Thanks,
> 
> Emil Sedgh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130324/aa37e59d/attachment-0001.html>