Review Request 109650: Use ContactsModel from the ContactList (in declarative)

[David Edmundson]

> On March 22, 2013, 8:20 a.m., David Edmundson wrote:
> > KTp/Declarative/contact-list.h, line 51
> > <http://git.reviewboard.kde.org/r/109650/diff/1/?file=120945#file120945line51>
> >
> >     This is not needed
> 
> Aleix Pol Gonzalez wrote:
>     Well, not needed but what's the point in not changing that?

because now you're making two ContactListModels
one here, and one is made inside KTp::ContactModel


> On March 22, 2013, 8:20 a.m., David Edmundson wrote:
> > KTp/Declarative/contact-list.cpp, line 40
> > <http://git.reviewboard.kde.org/r/109650/diff/1/?file=120946#file120946line40>
> >
> >     you do not need to, and should not call setSourceModel on the ContactsModel, it contains the ContactListModel internally
> >     
> >     I should probably make it protected in the  API.
> 
> Aleix Pol Gonzalez wrote:
>     It was there already before...

yes and it was needed then, but now it isn't because you've changed something and in fact this will break many things.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109650/#review29674
-----------------------------------------------------------


On March 22, 2013, 1:42 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109650/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 1:42 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> A suggested by David, use KTp::ContactsModel instead of KTp::ContactsFilterModel.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/contact-list.h a598144 
>   KTp/Declarative/contact-list.cpp 18b1332 
>   KTp/Declarative/qml-plugins.cpp e754b25 
> 
> Diff: http://git.reviewboard.kde.org/r/109650/diff/
> 
> 
> Testing
> -------
> 
> I ran this, and it still lists contacts, so I have no idea why it doesn't work. Maybe it's just too late... Ideas?
> 
> import QtQuick 1.1
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.components 0.1 as PlasmaComponents
> import org.kde.plasma.extras 0.1 as PlasmaExtras
> import org.kde.telepathy 0.1 as KTp
> 
> ListView {
>     KTp.ContactList {
>         id: groups
>         Component.onCompleted: {
>             model.groupMode = KTp.ContactsModel.GroupGrouping
>         }
>     }
>     height: 100
>     width: 200
>     model: groups.model
>     delegate: PlasmaComponents.ListItem {
>         width: parent.width
>         height: 20
>         PlasmaComponents.Label { text: display }
>     }
> }
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130322/29043edc/attachment.html>