Review Request 109560: Provide a static method to set WmClass

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109560/#review29679
-----------------------------------------------------------


In case you want to use that: be aware that you cannot just use X11 code in your application without testing for X11. I somehow doubt that your CMake is written in a way to prevent building on non-X11 systems.

- Martin Gräßlin


On March 18, 2013, 4:01 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109560/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 4:01 a.m.)
> 
> 
> Review request for Telepathy and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Provide a static method to set WmClass
> 
> This allows us to group all KTp windows together
> 
> See https://bugs.kde.org/show_bug.cgi?id=298470
> 
> 
> After using it, I'm not 100% sure I want the change.  Lets keep all discussion on that on bugzilla.
> 
> CC'ing Martin G because it involves X and he really likes X.
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt def690d62d0bbba56acf318a73a193bbc2f45994 
>   KTp/telepathy-handler-application.h 4f8a059cdcb54bffcc12e179151bf190ef170fc2 
>   KTp/telepathy-handler-application.cpp 8056dd1b55a1c74dfbb4dfa7357887a0afb54f9d 
> 
> Diff: http://git.reviewboard.kde.org/r/109560/diff/
> 
> 
> Testing
> -------
> 
> Added corresponding line to both the contact list and text-ui.
> 
> Both windows showed when I pressed cntrl+F7 also both share the same icon in the task manager.
> TBH, I'm not sure I like the behaviour.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130322/c09acd7b/attachment.html>