Review Request 109492: Allow Rich Text in QML notifications plasmoid

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109492/#review29558
-----------------------------------------------------------

Ship it!


I'm ok with this, though I have two reservations:

* other notification systems do not support rich text
* we should probably define a subset of rich text that is guaranteed to be supported

- Aaron J. Seigo


On March 17, 2013, 10:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109492/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 10:22 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Telepathy.
> 
> 
> Description
> -------
> 
> Allow Rich Text in QML Notification plasmoid
> 
> This matches behaviour of the notifications in 4.9 which used QLabel
> It fixes a problem we noticed in KTp in which we would see notifications with   > in the body as we deliberately try and keep formatting the same and be HTML safe.
> 
> I want to backport this to 4.10 branch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ed8ed99f92b7b5e7c2b491bd8d13d3eadb3d65db 
> 
> Diff: http://git.reviewboard.kde.org/r/109492/diff/
> 
> 
> Testing
> -------
> 
> Emitted notifications which were known to trigger the bug.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130320/c9bb7deb/attachment.html>