Review Request 109599: Fix presence applet activation of contac list part 1/2

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109599/#review29547
-----------------------------------------------------------



presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/109599/#comment22028>

    is "!connection.isConnected()" even possible?



presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/109599/#comment22032>

    org.freedesktop.DBus has a NameHasOwner method returning a boolean that you can use instead of ListNames to avoid "contains" later



presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/109599/#comment22033>

    Does the dbus call make it slower?
    I'd rather create a QDBusServiceWatcher[1] at startup and connect to the signals, so that you already know if it is running or not when the user clicks is
    
    [1]https://qt-project.org/doc/qt-4.8/qdbusservicewatcher.html


- Daniele E. Domenichelli


On March 20, 2013, 12:05 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109599/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 12:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This extends Dan's patch with a method in contact list, which will be part 2/2.
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.h f4889d6 
>   presence/src/presence-applet.cpp 58b6737 
> 
> Diff: http://git.reviewboard.kde.org/r/109599/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130320/28ce6a4c/attachment-0001.html>