Review Request 109599: Fix presence applet activation of contac list part 1/2

David Edmundson david at davidedmundson.co.uk
Wed Mar 20 11:43:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109599/#review29536
-----------------------------------------------------------

Ship it!


An investigation to do, then ship it, if it's not a problem.


presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/109599/#comment22023>

    Does isServiceRegistered block?


- David Edmundson


On March 20, 2013, 11:31 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109599/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 11:31 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This extends Dan's patch with a method in contact list, which will be part 2/2.
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.cpp 58b6737 
>   presence/src/presence-applet.h f4889d6 
> 
> Diff: http://git.reviewboard.kde.org/r/109599/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130320/36429311/attachment.html>


More information about the KDE-Telepathy mailing list