Review Request 109596: Simplify extension matching in image filtering
Dan Vrátil
dvratil at redhat.com
Tue Mar 19 23:44:41 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109596/#review29518
-----------------------------------------------------------
filters/images/images-filter.cpp
<http://git.reviewboard.kde.org/r/109596/#comment22018>
This is case-sensitive, so images with ".jpg" or ".JpG" filename extensions won't work.
- Dan Vrátil
On March 20, 2013, 12:31 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109596/
> -----------------------------------------------------------
>
> (Updated March 20, 2013, 12:31 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Simplify extension matching in image filtering
>
> This also fixes a bug in which the filter would match
> urls that features .jpg or .png at any point in the filename not just at the end
>
>
> Diffs
> -----
>
> filters/images/images-filter.cpp 1036d5bc051d110bc2916a574da374913e821057
>
> Diff: http://git.reviewboard.kde.org/r/109596/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130319/7c888e11/attachment.html>
More information about the KDE-Telepathy
mailing list