Review Request 109577: Show context menu for new contact requests on left click

Martin Klapetek martin.klapetek at gmail.com
Tue Mar 19 10:09:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109577/#review29492
-----------------------------------------------------------

Ship it!



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/109577/#comment22005>

    exec is blocking, use popup()


- Martin Klapetek


On March 19, 2013, 2:56 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109577/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 2:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Show context menu for new contact requests on left click.
> 
> BUG: 298009
> 
> 
> Right now left click does nothing.
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.h 649bd511da0873a9d0af29ab9d79d073afadf832 
>   contact-request-handler.cpp fa422d1b67237fd193ba36a8dab92967ddab05a7 
> 
> Diff: http://git.reviewboard.kde.org/r/109577/diff/
> 
> 
> Testing
> -------
> 
> Requested auth from a new contact. Clicked it :)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130319/346f5152/attachment-0001.html>


More information about the KDE-Telepathy mailing list