Review Request 109481: Simplify the Nepomuk data extraction Code

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109481/
-----------------------------------------------------------

(Updated March 18, 2013, 3:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Martin Klapetek.


Description
-------

    Simplify the Nepomuk data extraction Code
    
    Instead of using the Nepomuk property URIs as keys in ContactItem we now
    use the roles instead. This simplifies the data extraction part from the
    model as we can keep a direct mapping in the query (Binding Name => Role)
    
    Additionally, the ContactItem class could also load the data on its own
    by using the Nepomuk Resource class. It now uses the same query as the
    PersonsModel and fetches all the data in one go. This is much faster and
    simpler. Though, it results in a little bit of code duplication.
    
    And finally, the ResourceWatcher now reloads the contacts which are
    modified instead of just changing those specific properties. This is
    done because in many cases such as - ImAccounts, Emails, Photos, and
    ContactGroups, one needs to query the Nepomuk DB in order to fetch more
    information.


Diffs
-----

  src/contact-item.h e970a6d 
  src/contact-item.cpp e6b8277 
  src/person-item.cpp 7a8f520 
  src/persons-model.cpp 4e82688 
  src/resource-watcher-service.h 8484162 
  src/resource-watcher-service.cpp 6aafb83 
  src/tests/duplicatestest.cpp 3ebde5a 

Diff: http://git.reviewboard.kde.org/r/109481/diff/


Testing
-------

Tested by using the ktp-contactlist. It looks the same in both the cases. 

Also tested the ResourceWatcher by -
* manually changing an imNickName of one contact and it got updated.
* Adding a nco:photo for a nco:PersonContact and it also got updated.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130318/7178d287/attachment.html>