Review Request 109535: suppress notifications while writing out messages from backlog

Commit Hook null at kde.org
Sun Mar 17 13:20:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109535/
-----------------------------------------------------------

(Updated March 17, 2013, 1:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

suppress notifications while writing out messages from backlog


This addresses bug 316175.
    http://bugs.kde.org/show_bug.cgi?id=316175


Diffs
-----

  lib/chat-widget.h 9eecc89b716b07dca852560e3c0e88b5e296a9c1 
  lib/chat-widget.cpp 4416d6896ce451c871eb75557825f5dcd6847797 

Diff: http://git.reviewboard.kde.org/r/109535/diff/


Testing
-------

Before: Had ktp-text-ui closed on the receiving end, notification with highlight plugin is enabled. Sent from another account a message with just my nick in it. Observed a notification right away and one when opening ktp-text-ui.

After: Did the same again with the fix. Only one notification appearing. None when ktp-text-ui is opening.


Thanks,

Stefan Eggers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130317/36cf1eb8/attachment.html>


More information about the KDE-Telepathy mailing list