Review Request 109535: suppress notifications while writing out messages from backlog

[Stefan Eggers]

> On March 17, 2013, 12:49 p.m., David Edmundson wrote:
> > Ship It!

Still have no commit access. So someone please do the actual commit for me. Thanks.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109535/#review29371
-----------------------------------------------------------


On March 17, 2013, 9:12 a.m., Stefan Eggers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109535/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 9:12 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> suppress notifications while writing out messages from backlog
> 
> 
> This addresses bug 316175.
>     http://bugs.kde.org/show_bug.cgi?id=316175
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h 9eecc89b716b07dca852560e3c0e88b5e296a9c1 
>   lib/chat-widget.cpp 4416d6896ce451c871eb75557825f5dcd6847797 
> 
> Diff: http://git.reviewboard.kde.org/r/109535/diff/
> 
> 
> Testing
> -------
> 
> Before: Had ktp-text-ui closed on the receiving end, notification with highlight plugin is enabled. Sent from another account a message with just my nick in it. Observed a notification right away and one when opening ktp-text-ui.
> 
> After: Did the same again with the fix. Only one notification appearing. None when ktp-text-ui is opening.
> 
> 
> Thanks,
> 
> Stefan Eggers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130317/a7592af9/attachment.html>